feat(lib): Remote write rule compression - #864
Merged
Merged
Conversation
MichaelThamm
commented
Sep 8, 2026
sed-i
reviewed
Sep 9, 2026
sed-i
left a comment
Contributor
There was a problem hiding this comment.
Recovery is a consumer re-publish after the key is removed manually or a remove integration op.
Should we document in the PR description the manual call to relation-set that fixes a downgrade?
This was referenced Sep 10, 2026
MichaelThamm
marked this pull request as ready for review
September 10, 2026 17:47
sinapah
approved these changes
Sep 10, 2026
Abuelodelanada
approved these changes
Sep 10, 2026
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We want compression to avoid hitting databag limits.
Solution
Related:
Negotiated compression, so no combination of lib versions loses alert rules. The Provider app databag advertises what it can read, consumer picks the best match:
Consumer:
_alert_rules_encoding(relation)inspects the remote app databag;_push_alerts_to_relation_databagencodes accordingly (prometheus_remote_write.py:656). Also pushes alerts on relation_changed, so a relation that started out plain upgrades to compressed once the flag lands.Provider:
_publish_alert_rules_encodings(leader-guarded) called fromupdate_endpoint,relation_changed, plus newleader_elected/upgrade_charmobservers so existing relations get the flag after a provider upgrade.Context
Provider rollback is the one uncovered skew: a downgraded provider can't erase its own
alert_rules_encodingskey, so the consumer keeps compressing. Recovery is a consumer re-publish after the key is removed manually or a remove integration op.TODO
Testing Instructions
With the tandem PRs in Otelcol and Mimir, we should test the compression end-to-end.
Upgrade Mimir, then Otelcol
Upgrade Otelcol, then Mimir
Upgrade Notes