feat: enable out-of-order samples - #865
Merged
Merged
Conversation
sinapah
marked this pull request as ready for review
September 14, 2026 17:46
MichaelThamm
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #564.
Similar to: canonical/mimir-operators#468
Solution
Add a charm config option called
out_of_order_time_window, named after the upstream config name that is disabled by default. It's a string that accepts the time units s, m, etc.Context
Look at the upstream docs for more details: https://prometheus.io/docs/prometheus/latest/configuration/configuration/#tsdb.
Testing Instructions
First, observe the "before" behaviour by following the steps in this comment: #564 (comment).
Then, pack and refresh the Promtheus charm. After you configure Prometheus to have an out of order window of 5 minutes (
juju config prom out_of_order_time_window=5m),the errors should now go away.There should be a
storagesection at the bottom of the config file, looking like:Upgrade Notes