You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The tests assert the exact results returned from a SeldonDeployment. However, neither our charm neither using ROCKs instead of upstream images should be able to break the seldonDeployments results, as long as they actually return a successful response. Thus, tests should assert that the response is a successful one and that they actually contain results.
What needs to get done
Modify tests assertion
Definition of Done
Tests assert based on response status and structure instead of specific results.
Context
The tests assert the exact results returned from a
SeldonDeployment. However, neither our charm neither using ROCKs instead of upstream images should be able to break the seldonDeployments results, as long as they actually return a successful response. Thus, tests should assert that the response is a successful one and that they actually contain results.What needs to get done
Modify tests assertion
Definition of Done
Tests assert based on response status and structure instead of specific results.