This repository was archived by the owner on Apr 9, 2025. It is now read-only.
tests: remove mocking of private ops class - #268
Open
tonyandrewmeyer wants to merge 1 commit into
Open
tonyandrewmeyer wants to merge 1 commit into
tonyandrewmeyer wants to merge 1 commit into
Conversation
orfeas-k
added a commit
to canonical/minio-operator
that referenced
this pull request
Dec 10, 2024
Remove mocking of private ops class according to canonical/operator#1369 and canonical/seldon-core-operator#268
orfeas-k
added a commit
to canonical/notebook-operators
that referenced
this pull request
Dec 10, 2024
Remove mocking of private ops class according to canonical/operator#1369 and canonical/seldon-core-operator#268
This was referenced Dec 10, 2024
orfeas-k
added a commit
to canonical/minio-operator
that referenced
this pull request
Dec 13, 2024
* Pin pip to 24.2 due to jazzband/pip-tools#2131 * Update python dependencies using 'tox -e update-requirements' * Remove unused pytest-lazy-fixture package * Remove mocking of private ops class according to canonical/operator#1369 and canonical/seldon-core-operator#268 Ref canonical/bundle-kubeflow#1177 Ref canonical/bundle-kubeflow#1185
orfeas-k
added a commit
to canonical/notebook-operators
that referenced
this pull request
Dec 13, 2024
* Pin pip to 24.2 due to jazzband/pip-tools#2131 * Update python dependencies using 'tox -e update-requirements' * Remove mocking of private ops class according to canonical/operator#1369 and canonical/seldon-core-operator#268 * Pin blinker due to seleniumbase/SeleniumBase#2782 Ref canonical/bundle-kubeflow#1177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_TestingModelBackendclass is private, so no subject to any compatibility guarantees. The test that mocks a method on this class will break in an upcoming ops release.The mocking is actually not required with modern ops, so can just be removed.