Supports the openstack key is stored in the file#279
Open
sergiocazzolato wants to merge 3 commits intocanonical:masterfrom
Open
Supports the openstack key is stored in the file#279sergiocazzolato wants to merge 3 commits intocanonical:masterfrom
sergiocazzolato wants to merge 3 commits intocanonical:masterfrom
Conversation
Currently the openstack backend reads the key ans use to as a password to authenticate. This change introduces an alternative to allow add a path into the key which points to a file with the password (as we do in google when we set the GOOGLE_APPLICATION_CREDENTIALS env var). This is usefull in the ci (using selft hosted runners in forked projects when secrets cannot be used to protect env vars), so the file can be protected from the github runner to be read, allowing just the spread binary to access that file (adding security and making sure it is not possible to read the env var).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the openstack backend reads the key ans use to as a password to authenticate. This change introduces an alternative to allow add a path into the key which points to a file with the password (as we do in google when we set the GOOGLE_APPLICATION_CREDENTIALS env var).
This is useful in the ci (using selft hosted runners in forked projects when secrets cannot be used to protect env vars), so the file can be protected from the github runner to be read, allowing just the spread binary to access that file (adding security and making sure it is not possible to read the env var).