Skip to content

chore: Update CI to use charmcraftcache - #305

Merged
mvlassis merged 14 commits into
mainfrom
cachifier/use-charmcraftcache
May 28, 2026
Merged

mvlassis merged 14 commits into
mainfrom
cachifier/use-charmcraftcache

Conversation

@mvlassis

Copy link
Copy Markdown
Contributor

Summary

This PR updates the CI to utilize charmcraftcache, by using actions from data-platform-workflows. The ci.yaml is very similar to the structure we have in our multi-repo charms, for example see https://github.com/canonical/knative-operators/blob/main/.github/workflows/ci.yaml.

Base issue: canonical/bundle-kubeflow#1429

@mvlassis
mvlassis requested a review from a team May 22, 2026 19:35
@mvlassis mvlassis closed this May 25, 2026
@mvlassis mvlassis reopened this May 25, 2026
mvlassis added 6 commits May 25, 2026 11:20
- Remove pyrightconfig.json
- Remove weekly_ci.yaml, add schedule cron to ci.yaml
- Add concurrency, workflow_call outputs, get-charm-paths-track job
- Use dynamic matrix for build/release jobs
- Fix release.yaml: on push trigger, ci-tests pattern, dynamic track
- Remove on_pull_request.yaml (backport labels)
Comment thread .github/workflows/ci.yaml Outdated
mvlassis added 4 commits May 26, 2026 14:21
The ci.yaml reusable workflow's build and release jobs request
'actions: read' (needed by charmcraftcache), but the caller job
in release.yaml did not grant this permission, causing a startup
failure. Add permissions: actions: read to the ci-tests job.

@dariofaccin dariofaccin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(blocking): we need to update also on_pull_request workflow not to reference old ones.

@mvlassis

Copy link
Copy Markdown
Contributor Author

I removed the unused jobs in on_pull_request.yaml in f443a72

@mvlassis
mvlassis merged commit f98583d into main May 28, 2026
13 checks passed
@mvlassis
mvlassis deleted the cachifier/use-charmcraftcache branch May 28, 2026 09:30
@ckfbot

ckfbot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Created backport PR for track/1.9:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-305-to-track/1.9
git worktree add --checkout .worktree/backport-305-to-track/1.9 backport-305-to-track/1.9
cd .worktree/backport-305-to-track/1.9
git reset --hard HEAD^
git cherry-pick -x f98583d827233fcd09727275e979f831a7d30c11

mvlassis added a commit that referenced this pull request Jun 3, 2026
* chore: update CI to use charmcraftcache

* chore: remove ambient integration tests

---------

Co-authored-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>
Co-authored-by: mvlassis <manos.vlassis@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants