Conversation
Add K8sBackupTargetRequirer integration to the velero-operator charm, enabling backup/restore operations via the k8s-backup-target relation interface alongside the existing velero-backup-config interface. - Integrate K8sBackupTargetRequirer in charm.py with relation event handlers and schedule reconciliation - Add create-backup and list-backups support for k8s-backup-target relations - Add integration tests for the full k8s-backup-target lifecycle (relate, refresh, backup, list, restore, unrelate) - Add unit tests for k8s-backup-target relation handling and backup spec resolution - Update test charm to provide k8s-backup-target endpoint Signed-off-by: jneo8 <james.lin@canonical.com>
dariofaccin
reviewed
Apr 3, 2026
dariofaccin
left a comment
dariofaccin
left a comment
Contributor
There was a problem hiding this comment.
Left a question and a suggestion.
For the rest, PR looks good.
- Rename deploy_velero_and_test_charm to deploy_velero_test_charm_and_s3_integrator to make it clear at first sight that s3-integrator is also deployed. - Extend remove_all_applications to verify that core Velero resources (Deployment, DaemonSet, ServiceAccount, Service) are cleaned up from the model namespace after the charms are removed. Signed-off-by: jneo8 <james.lin@canonical.com>
dariofaccin
approved these changes
Apr 8, 2026
Contributor
Author
|
Hi @Deezzir can I get your approval for this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add K8sBackupTargetRequirer integration to the velero-operator charm, enabling backup/restore operations via the k8s-backup-target relation interface alongside the existing velero-backup-config interface.