Skip to content

Feature/render only once #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hammat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/render only once #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a83fba5
Merge branch 'release/1.21' into develop
canton7 Feb 16, 2013
370cf7d
Make sure casset renders each file only once
Jul 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions classes/casset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,7 @@ protected static function files_to_render($type, $group)
// Add it to the list of rendered groups
array_push(static::$rendered_groups[$type], $group_name);

$added = array();
foreach (static::$groups[$type][$group_name]['files'] as $file_set)
{
if (static::$groups[$type][$group_name]['min'])
Expand All @@ -1081,10 +1082,14 @@ protected static function files_to_render($type, $group)
$assets = static::find_files($file_set[0], $type);
}
foreach ($assets as $file) {
array_push($files[$group_name], array(
'file' => $file,
'minified' => $minified,
));
if (!in_array($file, $added))
{
array_push($files[$group_name], array(
'file' => $file,
'minified' => $minified,
));
$added[] = $file;
}
}
}
}
Expand Down