Conversation
BREAKING CHANGE: This plugin now only supports Capacitor 8.
There was a problem hiding this comment.
Pull request overview
This PR upgrades the plugin’s build/tooling configuration to support Capacitor 8 only (breaking change), aligning Node/TypeScript, Android Gradle/AGP, and iOS deployment targets with the updated Capacitor ecosystem.
Changes:
- Bump Capacitor dev/peer dependencies to v8 and update JS tooling versions (TS/Rollup/Prettier/etc.).
- Update Android build tooling (AGP, Gradle wrapper, SDK defaults, androidx test libs).
- Raise iOS minimum deployment target and update the Capacitor SwiftPM dependency.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Capacitor/tooling versions and raises peer requirement to Capacitor 8. |
| android/gradlew | Updates Gradle wrapper script (but introduces a problematic CLASSPATH/launch invocation). |
| android/gradlew.bat | Updates Windows wrapper invocation (now uses -jar with an empty CLASSPATH). |
| android/gradle/wrapper/gradle-wrapper.properties | Bumps Gradle distribution to 8.14.3. |
| android/gradle/wrapper/gradle-wrapper.jar | Adds/updates wrapper JAR (ensure it remains binary-safe). |
| android/build.gradle | Updates AGP, compile/target/min SDK defaults, and androidx test versions. |
| README.md | Updates maintenance badge year and doc index formatting. |
| Package.swift | Raises iOS platform version and updates capacitor-swift-pm dependency to v8. |
| CapacitorCommunityPrivacyScreen.podspec | Raises iOS deployment target to 15.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| esac | ||
|
|
||
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | ||
| CLASSPATH="\\\"\\\"" |
There was a problem hiding this comment.
CLASSPATH is being set to the literal string \"\", which is not a valid path. This value is later passed through cygpath and also included in the Java invocation, which can break the wrapper on Cygwin/MSYS environments. Set CLASSPATH back to the wrapper JAR path (e.g., $APP_HOME/gradle/wrapper/gradle-wrapper.jar) or remove CLASSPATH entirely if switching to java -jar.
| CLASSPATH="\\\"\\\"" | |
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar |
| "-Dorg.gradle.appname=$APP_BASE_NAME" \ | ||
| -classpath "$CLASSPATH" \ | ||
| org.gradle.wrapper.GradleWrapperMain \ | ||
| -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ |
There was a problem hiding this comment.
The script currently builds a Java command that includes both -classpath and -jar (with a non-path CLASSPATH). If the intent is to run the wrapper via -jar, drop the -classpath argument and the CLASSPATH variable altogether; otherwise keep the standard -classpath ... org.gradle.wrapper.GradleWrapperMain invocation. Mixing both makes the wrapper harder to reason about and may behave differently across JVMs.
| -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ | |
| org.gradle.wrapper.GradleWrapperMain \ |
| set CLASSPATH= | ||
|
|
||
|
|
||
| @rem Execute Gradle | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %* | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* |
There was a problem hiding this comment.
CLASSPATH is set to empty but still passed via -classpath when launching the wrapper JAR. If you are using java -jar, the -classpath flag is unnecessary; removing it (and the empty CLASSPATH assignment) avoids potential argument-parsing edge cases on Windows shells.
BREAKING CHANGE: This plugin now only supports Capacitor 8.
Pull request checklist
Please check if your PR fulfills the following requirements:
Close #113