Skip to content

feat!: update to Capacitor 8#119

Merged
robingenz merged 1 commit intomainfrom
feat/issue-113
Apr 28, 2026
Merged

feat!: update to Capacitor 8#119
robingenz merged 1 commit intomainfrom
feat/issue-113

Conversation

@robingenz
Copy link
Copy Markdown
Member

BREAKING CHANGE: This plugin now only supports Capacitor 8.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.

Close #113

BREAKING CHANGE: This plugin now only supports Capacitor 8.
@robingenz robingenz self-assigned this Apr 28, 2026
Copilot AI review requested due to automatic review settings April 28, 2026 11:22
@robingenz robingenz added the feature Feature label Apr 28, 2026
@robingenz robingenz merged commit 650e601 into main Apr 28, 2026
4 checks passed
@robingenz robingenz deleted the feat/issue-113 branch April 28, 2026 11:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the plugin’s build/tooling configuration to support Capacitor 8 only (breaking change), aligning Node/TypeScript, Android Gradle/AGP, and iOS deployment targets with the updated Capacitor ecosystem.

Changes:

  • Bump Capacitor dev/peer dependencies to v8 and update JS tooling versions (TS/Rollup/Prettier/etc.).
  • Update Android build tooling (AGP, Gradle wrapper, SDK defaults, androidx test libs).
  • Raise iOS minimum deployment target and update the Capacitor SwiftPM dependency.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Updates Capacitor/tooling versions and raises peer requirement to Capacitor 8.
android/gradlew Updates Gradle wrapper script (but introduces a problematic CLASSPATH/launch invocation).
android/gradlew.bat Updates Windows wrapper invocation (now uses -jar with an empty CLASSPATH).
android/gradle/wrapper/gradle-wrapper.properties Bumps Gradle distribution to 8.14.3.
android/gradle/wrapper/gradle-wrapper.jar Adds/updates wrapper JAR (ensure it remains binary-safe).
android/build.gradle Updates AGP, compile/target/min SDK defaults, and androidx test versions.
README.md Updates maintenance badge year and doc index formatting.
Package.swift Raises iOS platform version and updates capacitor-swift-pm dependency to v8.
CapacitorCommunityPrivacyScreen.podspec Raises iOS deployment target to 15.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread android/gradlew
esac

CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
CLASSPATH="\\\"\\\""
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLASSPATH is being set to the literal string \"\", which is not a valid path. This value is later passed through cygpath and also included in the Java invocation, which can break the wrapper on Cygwin/MSYS environments. Set CLASSPATH back to the wrapper JAR path (e.g., $APP_HOME/gradle/wrapper/gradle-wrapper.jar) or remove CLASSPATH entirely if switching to java -jar.

Suggested change
CLASSPATH="\\\"\\\""
CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar

Copilot uses AI. Check for mistakes.
Comment thread android/gradlew
"-Dorg.gradle.appname=$APP_BASE_NAME" \
-classpath "$CLASSPATH" \
org.gradle.wrapper.GradleWrapperMain \
-jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script currently builds a Java command that includes both -classpath and -jar (with a non-path CLASSPATH). If the intent is to run the wrapper via -jar, drop the -classpath argument and the CLASSPATH variable altogether; otherwise keep the standard -classpath ... org.gradle.wrapper.GradleWrapperMain invocation. Mixing both makes the wrapper harder to reason about and may behave differently across JVMs.

Suggested change
-jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
org.gradle.wrapper.GradleWrapperMain \

Copilot uses AI. Check for mistakes.
Comment thread android/gradlew.bat
Comment on lines +73 to +77
set CLASSPATH=


@rem Execute Gradle
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %*
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLASSPATH is set to empty but still passed via -classpath when launching the wrapper JAR. If you are using java -jar, the -classpath flag is unnecessary; removing it (and the empty CLASSPATH assignment) avoids potential argument-parsing edge cases on Windows shells.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants