Repository navigation
perf: answer pages from memory and revalidate in the background - #2
Merged
Merged
Conversation
Every page used to start external processes and could wait for NuGet and GitHub. Pages now answer from memory, and each one compares itself afterwards, so an outside change still appears on its own. Every change refreshes the data before its result is shown. The release catalog is stored on disk, so a normal start no longer depends on the network. Assets are cached for good through a version in their URL. NuGet search asks the API directly and falls back to the CLI, keeps old results until new ones arrive and remembers repeated queries. The Settings page now also names the NuGet search host Cockpit already used. A new benchmark measures click and key press to visible result on the native binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Cockpit feel immediate. Pages no longer wait for external processes or the network.
What changes
LiveDatareads the machine in the background. Each page compares itself once after loading and reloads if something changed outside Cockpit. Every change in Cockpit refreshes the data before its result is shown.azuresearch-usnc.nuget.org, which Cockpit already used.npm --prefix ui run benchmeasures click and key press to visible result against the native binary.Results on the native AOT build (median)
All 33 measures were within budget on one Mac in headless Chromium.
Trade-off
A page can show a slightly older state for a moment. It corrects itself about 0.4 s after loading, which is visible after changes made outside Cockpit.