Allow specifying both start and end date for transaction downloads#60
Open
DylanDonkersgoed wants to merge 2 commits intocaptin411:masterfrom
Conversation
…ions, making it possible to collect transactions between Y days before X and X
|
Is this still working? If so why hasn't this been merged? I think this should also change the cli for those who use it. |
…e-for-transaction-downloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow specifying both start and end date for transaction downloads, making it possible to collect transactions between Y days before X and X.
I'm not super familiar with GitHub (I usually develop for Drupal) and I think this is my first PR, so I hope I'm following the correct procecure. This is related to Allow specifying both start and end date for transaction downloads.
The way I've solved this is by adding an additional end date argument to Account::transactions() and various methods it calls. The API is a little weird (since you specify the days before followed by the end date rather than start and end date) but it should be backwards compatible with old code.
I'm not sure if this is 100% ready to be merged in or if the tests should be updated first. Haven't figured out how to run them yet (not super familiar with Python either).
I've been running this fix since I think October of 2018 and it works for my purposes at least. Code looks something like this: