-
Notifications
You must be signed in to change notification settings - Fork 14
Fix MotherDuck hanging on concurrent scripts, bump to 0.18.0 #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| # Changelog | ||
|
|
||
| ## Unreleased | ||
| ## v0.18.0 | ||
|
|
||
| ### Breaking changes | ||
|
|
||
| - Replaced provider-specific DuckLake secret env vars (`LEA_DUCKLAKE_R2_KEY_ID`, `LEA_DUCKLAKE_GCS_KEY_ID`, `LEA_DUCKLAKE_S3_ENDPOINT`, etc.) with a single `LEA_DUCKLAKE_SECRET` variable. The value is the body of a DuckDB [`CREATE SECRET`](https://duckdb.org/docs/current/configuration/secrets_manager) statement. Same for quack mode with `LEA_QUACK_DUCKLAKE_SECRET`. This supports any secret type DuckDB supports (S3, GCS, R2, Azure, etc.) without lea needing provider-specific code. | ||
|
|
||
| ### Bug fixes | ||
|
|
||
| - Fixed MotherDuck hanging when running concurrent scripts. The `MotherDuckClient` now uses a persistent connection with cursor-based thread safety, matching the pattern used by `DuckLakeClient`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,22 @@ | ||
| # Using MotherDuck | ||
| # MotherDuck | ||
|
|
||
| lea works with DuckDB, and thus can be used with [MotherDuck](https://motherduck.com/) too. | ||
| This example runs the [jaffle shop](../jaffle_shop/) pipeline on [MotherDuck](https://motherduck.com/). Local CSV files are read via hybrid execution and materialized as tables in MotherDuck. | ||
|
|
||
| Here is an example `.env` file: | ||
| Create a token at [app.motherduck.com/settings/tokens](https://app.motherduck.com/settings/tokens). | ||
|
|
||
| ```sh | ||
| echo " | ||
| LEA_USERNAME=max | ||
| LEA_WAREHOUSE=duckdb | ||
| LEA_DUCKDB_PATH=md:jaffle_shop | ||
| MOTHERDUCK_TOKEN=<provided by MotherDuck> | ||
| LEA_WAREHOUSE=motherduck | ||
| LEA_MOTHERDUCK_DATABASE=jaffle_shop | ||
| MOTHERDUCK_TOKEN=<your token> | ||
| " > .env | ||
| ``` | ||
|
|
||
| The token can be obtained by logging into MotherDuck from the terminal, as documented [here](https://motherduck.com/docs/getting-started/connect-query-from-python/installation-authentication#authenticating-to-motherduck). | ||
|
|
||
| ```sh | ||
| lea run ../jaffle_shop/views | ||
| ln -s ../jaffle_shop/jaffle_shop jaffle_shop | ||
| ``` | ||
|
|
||
| ```sh | ||
| lea run --scripts ../jaffle_shop/scripts | ||
| ``` | ||
| Created schema analytics | ||
| Created schema staging | ||
| Created schema core | ||
| ``` | ||
|
|
||
| You should see the views in your MotherDuck UI. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.