Skip to content

new_processes-assembly-finishing-printing#32

Open
VinceC-png wants to merge 5 commits into
mainfrom
add_new_processes
Open

new_processes-assembly-finishing-printing#32
VinceC-png wants to merge 5 commits into
mainfrom
add_new_processes

Conversation

@VinceC-png
Copy link
Copy Markdown
Contributor

@VinceC-png VinceC-png commented May 12, 2026

Adding folders for 3 new process types:

  • finishing
  • printing
  • textile-assembly

Files generated in each folder:

  • inventory-brightway.xlsx
  • impact-scores.csv
  • README.md

Files to generate in a future PR:

  • All methodological documents

Summary by cubic

Add three new LCA process categories—finishing, printing, and textile-assembly—with 49 datasets, EF 3.1 results, and Brightway-compatible inventories. For printing and assembly, scale upstream substrate/fabric by Input_required_kg and add a textile-waste flow; finishing uses Input_required_kg=1.

  • New Features

    • Added datasets/finishing, datasets/printing, datasets/textile-assembly with README.md, impact-scores.csv, and inventory-brightway.xlsx.
    • Coverage: 18 finishing, 16 printing, 15 assembly datasets; all include 16 EF 3.1 indicators, DQR fields, and Input_required_kg (finishing = 1).
  • Bug Fixes

    • Removed duplicate activity rows in impact-scores.csv to ensure one record per process.

Written for commit 1812918. Summary will update on new commits.

@VinceC-png VinceC-png requested a review from lvandepaer as a code owner May 12, 2026 08:25
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 9 files

Confidence score: 3/5

  • There is a concrete medium-high risk in datasets/finishing/impact-scores.csv: reusing the same descriptor key for two different heat-setting datasets can cause downstream row collisions and incorrect joins/overwrites.
  • The two README link issues in datasets/textile-assembly/README.md and datasets/printing/README.md are low severity and primarily documentation-impacting, so they are unlikely to block core functionality.
  • This is not a critical blocker, but the confirmed data-key collision (7/10 severity, high confidence) introduces real regression risk, which is why this sits at moderate merge risk rather than safe-to-merge.
  • Pay close attention to datasets/finishing/impact-scores.csv, datasets/textile-assembly/README.md, and datasets/printing/README.md - resolve the duplicate key and fix broken methodology links to avoid downstream processing and documentation confusion.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="datasets/printing/README.md">

<violation number="1" location="datasets/printing/README.md:38">
P3: This README links to a `methodology/` path that is not included in this PR, so the documentation link is currently broken.</violation>
</file>

<file name="datasets/finishing/impact-scores.csv">

<violation number="1" location="datasets/finishing/impact-scores.csv:20">
P1: Duplicate `descriptor` key is used for two different heat-setting datasets, which can cause row collisions in downstream processing.</violation>
</file>

<file name="datasets/textile-assembly/README.md">

<violation number="1" location="datasets/textile-assembly/README.md:37">
P2: This README links to a methodology folder that is not part of this PR, resulting in a dead link.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread datasets/finishing/impact-scores.csv Outdated
Comment thread datasets/textile-assembly/README.md Outdated
Comment thread datasets/printing/README.md Outdated
VinceC-png and others added 3 commits May 12, 2026 10:35
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@VinceC-png VinceC-png self-assigned this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant