Group realm server tests into larger shards #3831
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1139a3ca0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/realm-server/package.json
Outdated
| "start:pg": "./scripts/start-pg.sh", | ||
| "stop:pg": "./scripts/stop-pg.sh", | ||
| "test:wait-for-servers": "WAIT_ON_TIMEOUT=900000 NODE_NO_WARNINGS=1 start-server-and-test 'pnpm run wait' 'http-get://localhost:4201/base/_readiness-check?acceptHeader=application%2Fvnd.api%2Bjson' 'pnpm run wait' 'http-get://localhost:4202/node-test/_readiness-check?acceptHeader=application%2Fvnd.api%2Bjson|http://localhost:8008|http://localhost:5001' 'test-module'", | ||
| "test:wait-for-servers": "WAIT_ON_TIMEOUT=900000 NODE_NO_WARNINGS=1 start-server-and-test 'pnpm run wait' 'http-get://localhost:4201/base/_readiness-check?acceptHeader=application%2Fvnd.api%2Bjson' 'pnpm run wait' 'http-get://localhost:4202/node-test/_readiness-check?acceptHeader=application%2Fvnd.api%2Bjson|http://localhost:8008|http://localhost:5001' 'test-modules'", |
There was a problem hiding this comment.
The test:wait-for-servers script now invokes a test-modules command, but this package only defines test and test-module scripts and no binary named test-modules exists, so the CI job that runs pnpm test:wait-for-servers will fail with “command not found.” This affects every realm-server test shard in .github/workflows/ci.yaml and any local runs of that script; consider switching back to pnpm test (it already honors TEST_MODULES) or add a test-modules script that wires to scripts/run-test-modules.js and the necessary env setup.
Useful? React with 👍 / 👎.
Host Test Results 1 files ± 0 1 suites ±0 1h 42m 30s ⏱️ + 11m 5s For more details on these errors, see this check. Results for commit 3cc9065. ± Comparison against base commit e19775a. This pull request removes 1 and adds 212 tests. Note that renamed tests count towards both. |
No description provided.