Skip to content

Conversation

@lucaslyl
Copy link
Contributor

@lucaslyl lucaslyl commented Jan 16, 2026

linear: https://linear.app/cardstack/issue/CS-10066/point-the-code-ref-of-field-spec-to-field

  • Update all field-spec instance JSON files to point ref.name and ref.module to the actual field classes in fields/ directory instead of field-spec files.

Demo:
image

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Host Test Results

    1 files  ±0      1 suites  ±0   1h 38m 44s ⏱️ +30s
1 875 tests ±0  1 860 ✅ ±0  15 💤 ±0  0 ❌ ±0 
1 890 runs  ±0  1 875 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit ce97998. ± Comparison against base commit ad44cf2.

♻️ This comment has been updated with latest results.

@lucaslyl lucaslyl force-pushed the CS-10066-point-the-code-ref-of-field-spec-to-field branch from 56de20c to 4de5abf Compare January 16, 2026 07:44
"readMe": null,
"ref": {
"module": "http://localhost:4201/catalog/fields/image/components/image-presentation",
"module": "../fields/image/components/image-presentation",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt delete these component spec because it used in one of the CardListing

@lucaslyl lucaslyl self-assigned this Jan 16, 2026
@lucaslyl lucaslyl requested a review from a team January 16, 2026 08:07
@lucaslyl lucaslyl marked this pull request as ready for review January 16, 2026 08:07
/>
</template>
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why having two exports? I think there are consequences to this when for example you auto create-specs? If you dont want the default name I wud say just remove the default export imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants