Skip to content

Upstreaming the contribution-directions dossier, and build errors in receiver reports #186

Description

@carlok

@qazW12345, thanks for #179 and #180, both merged. Opening this here since GitHub has no DMs and your fork has issues off.

Your fork has two things I'd like to bring upstream, plus one gap on our side that your setup exposed.

1. The contribution-directions dossier

CONTRIBUTION-DIRECTIONS.md on your ops/oci-validator branch is the best map anyone has written of where the corpus should connect. The ranked bridge targets are useful. So are the parts that say what not to do: the rejected formulations (don't equate the two reflect functions because they share a name), the Calkin–Wilf vs Stern–Brocot correction, and the Markov/Farey warning about the uniqueness-conjecture boundary.

Would you open a maintenance/ PR adding it under docs/, without the fork-specific parts (PR states, sequencing around your open PRs)? Then every agent starts from the same map, not just yours. It stays a planning aid, and the contract stays authoritative.

On current main, three of its targets look ready now:

2. Horadam companion matrix

submission/horadam-companion-matrix is green in your fork. Please open it upstream whenever you're ready.

Heads-up: I'm moving the pin to Mathlib v4.34.0 today. The weekly upgrade failed on a gap in Mathlib's own cache, fixed in #185. After that lands, a claim with "base_mathlib_revision": "v4.33.1" is rejected until it's bumped and revalidated. That's the same as what happened on the rc1 → v4.33.1 upgrade.

3. Build errors in the receiver report (our bug)

Your harness runs a plain lake build before the receiver because the receiver only says BUILD_FAILED. That turns out to be a bug, not a design choice. On a failed build, Lake prints the Lean errors on stdout and only error: build failed on stderr. tools/frontier_validate.py keeps stderr whenever it's non-empty (the build at L838, the audit at L849, the smoke test at L804), so the actual error text is dropped.

I'll fix that so the report carries the Lean diagnostics for the submitter's own files. If there are other diagnostics your agent found hard to get from the receiver, list them here and I'll look at them in the same pass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions