Skip to content

chore(deps): remove the zip advisory ignores, Cargo.lock is on zip 9 - #36

Open
zyl71 wants to merge 1 commit into
carloseduardo21:mainfrom
zyl71:remove-stale-advisory-ignores
Open

zyl71 wants to merge 1 commit into
carloseduardo21:mainfrom
zyl71:remove-stale-advisory-ignores

Conversation

@zyl71

@zyl71 zyl71 commented Nov 20, 2026 •

Copy link
Copy Markdown

Closes #35

src-tauri/.cargo/audit.toml and src-tauri/deny.toml still ignore the advisories below, but src-tauri/Cargo.lock on main already holds a patched version of the crate, so the entries no longer suppress anything. This pull request removes them, together with the comments that explained them.

Advisory Summary In src-tauri/Cargo.lock now Patched in Severity
RUSTSEC-2026-0369 ZipStreamReader::extract() and ZipArchive::extract() apply Unix permissions … zip 9.3.0 9.0.0 critical
RUSTSEC-2026-0367 Insecure Preservation of SUID/SGID Bits during ZIP Extraction Leading to … zip 9.3.0 9.0.0 high
RUSTSEC-2026-0429 zip: ZipArchive::extract aborts the process on a symlink entry with a large … zip 9.3.0 9.0.0 high
RUSTSEC-2026-0368 zip: ZipArchive::extract creates symbolic links whose attacker-controlled … zip 9.3.0 9.0.0 not scored

Why remove them. An ignore entry keeps muting the advisory id for as long as it stays in the file. If the crate were later pinned back to an affected version, cargo-audit and cargo-deny would stay silent about it.

What was checked, and what was not.

  • Read from main at commit 4613fc5caf10 on 2026-11-20: each id is on an active line of the config, and no version of the affected crate in src-tauri/Cargo.lock is inside the affected range of its advisory (RustSec records).
  • The change touches only src-tauri/.cargo/audit.toml and src-tauri/deny.toml. No Rust source and no lock file is changed. The edited files parse as TOML, and every other ignore entry and setting is unchanged.
  • We did not run cargo audit or cargo deny check advisories locally, because we do not build or execute anything from this repository. CI is the first run of the tool on this change.

Not part of this change, but possibly useful: cargo-deny reports such entries as advisory-not-detected warnings, and unused-ignored-advisory = "deny" under [advisories] turns them into errors.

Disclosure: the check, the edit and this text were produced with automated tooling, including an LLM.

Feel free to close this if it is not useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 advisory ignore entries no longer match anything (zip already patched in src-tauri/Cargo.lock)

1 participant