Run the test suites on both platforms, and in CI - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither test suite ran anywhere: both hardcode
libm.so.6, so they fail on macos, and CI ran neither. Stacked on #6, which is wheretest/typed.carpcomes from.test/platform.carppicks the library per platform off core'smac-target?, so the suites run on both runners.test/typed.carpreported a faileddlopenor a failed binding withIO.errorlnand then passed anyway, so it could only ever be green. it now asserts throughTest, liketest/dynlib.carp, and carries the error text into the failure message.carp -x test/*.carponly executes one file, so they are listed separately.on macos:
test/dynlib.carp6 assertions (was 1 of 6 passing),test/typed.carp5. pointed at a deliberately missing library both go red, 5 of 6 and 5 of 5.the readme example carries a comment naming both paths, since the snippet as written only runs on glibc.