Decode a multipart upload from the request bytes, not from a String - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request buffer was turned into a
Stringbefore parsing, so amultipart/form-databody was cut at its first NUL byte, taking the closing delimiter with it. The handler got aResult.Successcarrying no parts and had nothing to check.Reproduced at the same shape the issue reports: a 123-byte body measures 109 as a
String, decodes to 0 parts, and the same body as text gives 1.Form.decode-multipart-request-bytesdecodes via http'sMultipart.parse-bytes, yieldingBinaryParts with(Array Byte)bodies.Request.bodystays aString, which is fine for every other route.&Requestand¶ms. Set once per request before the hooks and the handler; a buffer whose framing does not parse leaves an empty body rather than the previous request's.TransferEncoding.dechunkon the truncatedStringbody, so a chunked binary upload was answered with a 400. This leaves one chunk decoder in the request path rather than two.Tests: 403 in
test/web.carp(7 new, covering trailing/embedded/all-NUL payloads, the chunked framing, and the fact that theStringpath still loses the part, which is why the byte one exists), 155 websocket, 18 cors. Two new end-to-end checks insmoke.shupload a real binary file through a running server, plain and chunked.Closes #66