Repository navigation
Give the SVG favicon an opaque square ground - #2
Merged
Merged
Conversation
The tab icon was invisible in browsers with a dark tab strip. Two causes, both mine: - carbo-logo.svg has no background. The mark is #1A1B1C, so on a dark tab strip a near-black shape on transparency disappears; only the light chin stayed visible. The handoff says this explicitly about the PNG icons — "the mark's negative space needs an opaque ground to read at small sizes" — and the PNGs were built that way. The SVG was not. - Its viewBox is 593x850, portrait. A favicon slot is square, so the mark was letterboxed and rendered smaller still. Declaring it first meant browsers preferred it over the correct PNGs. assets/favicon.svg is now a square 1000x1000 with a #FBFCFE ground and the mark centred at 84%, matching the PNG icons. Compared side by side at 16/24/32/64px against both dark and light grounds before and after. carbo-logo.svg stays the header lockup: transparent is right there, since it sits on paper. Dropping the C2PA metadata blob also took the icon from 39 KB to 31 KB. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab icon was invisible in browsers with a dark tab strip.
Cause
Two, both introduced when the SVG favicon was added:
carbo-logo.svghas no background. The mark is#1A1B1C, so on a dark tab strip a near-black shape on transparency disappears; only the light chin stayed visible. The handoff states this explicitly about the PNG icons ("the mark's negative space needs an opaque ground to read at small sizes") and the PNGs were generated that way. The SVG was not.viewBoxis593x850, portrait. A favicon slot is square, so the mark was letterboxed and rendered smaller still.Declaring the SVG first meant browsers preferred it over the perfectly good PNGs.
Fix
assets/favicon.svg: square1000x1000,#FBFCFEground, mark centred at 84%, matching the PNG icons. Verified side by side at 16/24/32/64px against dark and light grounds — the old asset is a dot at 16px on dark, the new one reads like the PNG reference.carbo-logo.svgremains the header lockup, where transparent is correct because it sits on paper.Dropping the C2PA metadata blob also took the icon from 39 KB to 31 KB.
Checks
Invariants, html-validate, linkinator (27 links), axe (4 pages, 0 violations), Lighthouse (9 runs, all assertions) all pass locally.
🤖 Generated with Claude Code