Slack event queues and connector by carterax · Pull Request #33 · carterax/overchat

carterax · 2025-10-19T00:34:41Z

No description provided.

Copilot

Pull Request Overview

Implements Slack event ingestion, queuing, and processing to convert Slack messages into platform Messages and optionally generate intents via the AI pipeline.

Adds SlackEvent Prisma model, migrations, and shared Zod schemas
Stores webhook events, introduces a SlackMessageProcessor to create messages and run analysis, and exposes GraphQL mutations to process events
Provides a Slack message adapter, test script, QA guide, and intent queries

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
scripts/test-slack-webhook.ts	Script to send a signed Slack webhook event for local testing
packages/shared/src/types/prisma/index.ts	Shared Zod schemas/types for new SlackEvent model and selectors/inputs
packages/external-services/src/slack/slack-message-adapter.ts	Adapter to convert Slack events to platform MessageCreateInput
packages/external-services/src/slack/index.ts	Re-exports Slack message adapter
packages/database/src/services/slack-message-processor.ts	Processes queued Slack events into Messages and triggers analysis
packages/database/src/services/slack-event.ts	Slack event queue service: store, fetch, mark processed/failed, retry
packages/database/src/services/index.ts	Exports SlackEventService and SlackMessageProcessor
packages/database/src/services/conversation-analysis.ts	Removes stray console.log
packages/database/src/services/tests/slack-event.test.ts	Tests for SlackEventService (skipped unless DATABASE_URL present)
packages/database/prisma/schema.prisma	Adds SlackEvent model and indices
packages/database/prisma/migrations/.../migration.sql	Migration adding SlackEvent and changing ExternalService enum
docs/SLACK_PHASE2_QA_GUIDE.md	End-to-end Slack Phase 2 QA guide
apps/api/src/plugins/slack-webhooks.ts	Stores Slack events on webhook receipt
apps/api/src/modules/slack/type.ts	GraphQL types for processing Slack events responses
apps/api/src/modules/slack/mutation.ts	GraphQL mutations to process events (channel/all)
apps/api/src/modules/intent/type.ts	Exposes intent reviewState in GraphQL
apps/api/src/modules/intent/query.ts	Adds intent and intents GraphQL queries with filters
apps/api/src/modules/enums/type.ts	Adds IntentReviewState enum; ExternalService enum unchanged

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

carterax · 2025-10-19T07:17:22Z

@codex please pr review

Copilot

Pull Request Overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 6 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

carterax · 2025-10-19T07:36:43Z

@codex review please

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

chatgpt-codex-connector · 2025-10-19T07:43:00Z

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull Request Overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

packages/shared/src/types/prisma/index.ts:1

payload is a JSON field, which Prisma does not support in orderBy clauses. Including payload here will cause invalid queries at runtime. Remove payload from the orderBy schemas to align with Prisma's capabilities.

import { z } from 'zod';

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-19T07:43:58Z

+            const enterpriseId = payload.authorizations?.[0]?.enterprise_id;
+            const isEnterpriseInstall = payload.authorizations?.[0]?.is_enterprise_install;
+            const workspaceId = (isEnterpriseInstall && enterpriseId) ? enterpriseId : payload.team_id;


workspaceId is stored using the raw Slack ID (e.g., T123/enterprise ID), while channel configuration and processors use normalized workspace keys (e.g., team:T123). This mismatch prevents queued events from being picked up and can cause duplicate conversation creation attempts. Normalize the workspace ID here using workspaceKey(...) so SlackEvent.workspaceId matches SlackChannelConfig.workspaceId and message metadata.

Copilot · 2025-10-19T07:43:58Z

+    const events = await SlackEventService.getUnprocessedEvents({
+      workspaceId,
+      channelId,
+      processedAt: null,
+    });


This filters SlackEvent by the function parameter workspaceId, which may not match the normalized workspaceId stored in SlackEvent (or the channel config). Use channelConfig.workspaceId for consistency to ensure events are found and processed.

Copilot · 2025-10-19T07:43:58Z

+    const messageInput = SlackMessageAdapter.toPlatformMessage(
+      payload,
+      conversationId,
+      event.workspaceId


Message metadata slackWorkspaceId is being populated from event.workspaceId, which is inconsistent with the normalized workspaceId used for conversations and channel config. Pass channelConfig.workspaceId here to keep metadata consistent and to avoid failing to find the existing conversation on subsequent runs.

Suggested change

event.workspaceId

channelConfig.workspaceId

Copilot · 2025-10-19T07:43:59Z

+    });
+
+    // Filter intents by confidence threshold
+    const threshold = channelConfig.autoApplyThreshold || 0.6;


Use nullish coalescing (??) instead of || to avoid treating 0 as falsy. Example: const threshold = channelConfig.autoApplyThreshold ?? 0.6;

Suggested change

const threshold = channelConfig.autoApplyThreshold || 0.6;

const threshold = channelConfig.autoApplyThreshold ?? 0.6;

Copilot · 2025-10-19T07:43:59Z

+  private async processEvent(
+    event: any,
+    conversationId: string,
+    channelConfig: any,
+    forceAnalysis?: boolean
+  ): Promise<boolean> {


channelConfig and forceAnalysis parameters are not used in this method. Consider removing them to reduce confusion, or use them if they are intended for logic here.

Copilot · 2025-10-19T07:43:59Z

+export const SlackEventOrderByWithAggregationInputSchema: z.ZodType<Prisma.SlackEventOrderByWithAggregationInput> = z.object({
+  id: z.lazy(() => SortOrderSchema).optional(),
+  eventId: z.lazy(() => SortOrderSchema).optional(),
+  eventType: z.lazy(() => SortOrderSchema).optional(),
+  workspaceId: z.lazy(() => SortOrderSchema).optional(),
+  channelId: z.lazy(() => SortOrderSchema).optional(),
+  threadTs: z.union([ z.lazy(() => SortOrderSchema),z.lazy(() => SortOrderInputSchema) ]).optional(),
+  messageTs: z.union([ z.lazy(() => SortOrderSchema),z.lazy(() => SortOrderInputSchema) ]).optional(),
+  userId: z.union([ z.lazy(() => SortOrderSchema),z.lazy(() => SortOrderInputSchema) ]).optional(),
+  payload: z.lazy(() => SortOrderSchema).optional(),
+  processedAt: z.union([ z.lazy(() => SortOrderSchema),z.lazy(() => SortOrderInputSchema) ]).optional(),
+  processingError: z.union([ z.lazy(() => SortOrderSchema),z.lazy(() => SortOrderInputSchema) ]).optional(),
+  retryCount: z.lazy(() => SortOrderSchema).optional(),
+  shouldRetry: z.lazy(() => SortOrderSchema).optional(),
+  createdAt: z.lazy(() => SortOrderSchema).optional(),
+  updatedAt: z.lazy(() => SortOrderSchema).optional(),
+  _count: z.lazy(() => SlackEventCountOrderByAggregateInputSchema).optional(),


payload should not be present in the orderBy-with-aggregation schema either; JSON fields are not sortable in Prisma. Remove payload from this schema to prevent invalid queries.

tsiq-ikennao added 3 commits October 19, 2025 01:27

add slack event queue

ff50055

passing tests

500c2bc

passing tests

885bbd7

carterax requested a review from Copilot October 19, 2025 00:34

Copilot AI reviewed Oct 19, 2025

View reviewed changes

chatgpt-codex-connector Bot reviewed Oct 19, 2025

View reviewed changes

Comment thread apps/api/src/plugins/slack-webhooks.ts Outdated

Comment thread packages/database/src/services/slack-message-processor.ts

carterax and others added 7 commits October 19, 2025 07:29

Update scripts/test-slack-webhook.ts

ce9a7e9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update packages/database/src/services/slack-message-processor.ts

3b4a564

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update packages/database/src/services/slack-message-processor.ts

8007575

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update docs/SLACK_PHASE2_QA_GUIDE.md

581b773

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update apps/api/src/modules/enums/type.ts

086bbfc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update docs/SLACK_PHASE2_QA_GUIDE.md

5dcf931

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

address pr comments

25663d0

carterax requested a review from Copilot October 19, 2025 07:19

fix enum value

60a9446

Copilot AI reviewed Oct 19, 2025

View reviewed changes

chatgpt-codex-connector Bot reviewed Oct 19, 2025

View reviewed changes

Comment thread apps/api/src/plugins/slack-webhooks.ts

address pr comments

b8a0026

Copilot AI reviewed Oct 19, 2025

carterax requested a review from Copilot October 19, 2025 07:40

carterax merged commit b322050 into main Oct 19, 2025
1 check failed

Copilot AI reviewed Oct 19, 2025

View reviewed changes

	const threshold = channelConfig.autoApplyThreshold \|\| 0.6;
	const threshold = channelConfig.autoApplyThreshold ?? 0.6;

Conversation

carterax commented Oct 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

carterax commented Oct 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

carterax commented Oct 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants