Conversation
ZzzzHui
force-pushed
the
feature/improve-bond
branch
from
501f552 to
37b151a
Compare
|
Hey @stephenctw , a test timed out. Not sure if you know what's wrong, by any chance? Thanks in advance |
Never see this before, I will take a closer look |
|
Thanks Stephen!! |
ZzzzHui
force-pushed
the
feature/improve-bond
branch
from
380eed6 to
d69a36c
Compare
|
Nice! Can you explain why the change in the smart contracts broke things, and why your fix fixed them? |
I might be wrong, but seems Alloy's estimate gas function was too conservative, hence many transactions were reverted silently because of running out of gas(after the bond improvements). You can also tell that the lua-client doesn't need to change a line. Meaning that "cast send" estimate tx gas pretty accurate. |
3 participants
No description provided.