Skip to content

Add ADIOS Image class#50

Open
vuo006 wants to merge 2 commits intocasacore:masterfrom
vuo006:master
Open

Add ADIOS Image class#50
vuo006 wants to merge 2 commits intocasacore:masterfrom
vuo006:master

Conversation

@vuo006
Copy link

@vuo006 vuo006 commented Mar 13, 2026

Add a new ADIOS Image class to casarest

vuo006 added 2 commits March 9, 2026 10:46
…ot needed. Added HAVE_ADIOS2 and HAVE_MPI as two separate variables in a cmake file as ADIOS can be use without MPI
@VoronkovMA VoronkovMA self-requested a review March 13, 2026 03:08
@VoronkovMA
Copy link
Collaborator

It is interesting why it didn't attempt to run CI. Last time I did anything with casarest it ran the CI. Although with this particular PR it won't change much as we don't have CI with ADIOS setup, so it would just be checking building without ADIOS.

@rtobar
Copy link

rtobar commented Mar 13, 2026

I think it's because the PR was created by the user vuo006 instead of VoronkovMA? Allegedly the latter is already known the the casarest repo, and therefore CI won't need approval, whereas vuo006 being new requires one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants