Open
Conversation
…ot needed. Added HAVE_ADIOS2 and HAVE_MPI as two separate variables in a cmake file as ADIOS can be use without MPI
Collaborator
|
It is interesting why it didn't attempt to run CI. Last time I did anything with casarest it ran the CI. Although with this particular PR it won't change much as we don't have CI with ADIOS setup, so it would just be checking building without ADIOS. |
|
I think it's because the PR was created by the user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new ADIOS Image class to casarest