Check channel freshness for install-on-activate packages during activation - #600
Open
joahg wants to merge 1 commit into
Open
Check channel freshness for install-on-activate packages during activation#600joahg wants to merge 1 commit into
joahg wants to merge 1 commit into
Conversation
Channel packages with an update interval are only checked for updates when one of their binary stubs is executed. Packages installed via install-on-activate may never be executed - e.g. packages whose purpose is to materialise content into the environment via triggers - so they currently remain stale indefinitely. Run the standard EnsureChannelIsUpToDate check in EnsureInstalled so activation keeps install-on-activate channel packages fresh. The check is a no-op for packages without an update interval, and for packages whose update check is not yet due. Buzz-Message: buzz://message?channel=573ff355-6c19-422d-b425-112853d0ec7e&id=16f5b666c0976829a1985868753407c7b20b393d89f99a8b39106be9fe6a1514 Amp-Thread-ID: https://ampcode.com/threads/T-019fce27-e59e-727c-b6d3-cdeeba894a4e Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #597 — composing agent-skills-style content packages from existing Hermit primitives.
Channel packages with an
updateinterval are only checked for updates when one of their binary stubs is executed. Packages installed viainstall-on-activatemay never be executed — e.g. packages whose purpose is to materialise content into the environment via triggers — so they currently remain stale indefinitely.This runs the standard
EnsureChannelIsUpToDatecheck inEnsureInstalledso activation keepsinstall-on-activatechannel packages fresh. The check is a no-op for packages without an update interval, and for packages whose update check is not yet due, so ordinary activations stay fast.Tested with
go test ./...andgolangci-lint run.