fix(wineCtx): Prevent TypeError from non-atomic game.runtime access - #124
Open
sentry[bot] wants to merge 1 commit into
Open
fix(wineCtx): Prevent TypeError from non-atomic game.runtime access#124sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue RUST-G, fixing a
TypeError: undefined is not an object (evaluating 'game.runtime.runtime')originating in thewineCtxfunction. The error was caused by a reactivity race condition in a Svelte 5 reactive context, wheregame.runtimecould re-evaluate toundefinedbetween non-atomic accesses.Changes
game?.runtimeinto a local variable (r) within thewineCtxfunction.wineCtxto use the cachedrfor both the null-check (!r) and the subsequent property access (r.runtime), ensuring atomic access.Testing
cargo test -p corkscrewpassesnpx svelte-check --threshold errorpassescargo tauri dev(if UI changes)Notes
The root cause was a reactivity race condition specific to how Svelte 5 handles reactive objects (Proxies). Accessing
game.runtimetwice non-atomically allowed theruntimeproperty to becomeundefinedbetween the initial check and subsequent use, leading to theTypeError.Fixes RUST-G