Add Kotlin JVM bindings#1797
Merged
Merged
Conversation
crodas
force-pushed
the
feature/binding-kotlin
branch
from
970ceea to
3b3123d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1797 +/- ##
==========================================
+ Coverage 62.51% 62.56% +0.04%
==========================================
Files 329 329
Lines 53644 53644
==========================================
+ Hits 33535 33560 +25
+ Misses 20109 20084 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crodas
force-pushed
the
feature/binding-kotlin
branch
2 times, most recently
from
0f8af0c to
f9e9944
Compare
Collaborator
thesimplekid
left a comment
thesimplekid
left a comment
There was a problem hiding this comment.
There are things done here that I left on comments on the Dart/Swift PR that I would like to address there before moving on. Multiple rust-toolchains, use of nix develop and not nix build.
Add Kotlin/JVM bindings for CDK using UniFFI, following the same pattern as the existing Dart and Swift bindings. Includes a Gradle project with JNA-based native library loading, a generate-bindings.sh build script, and JUnit 5 integration tests (initial balance, mint flow) mirroring the Dart test suite.
Add missing rust-toolchain.toml to Kotlin bindings and update Dart and Swift toolchain pins from 1.90.0 to 1.94.0 to match the workspace.
Move Dart and Kotlin binding generation from shell scripts run inside nix develop to proper Crane derivations (dartBindings, kotlinBindings) that benefit from Cachix caching. The expensive Rust cdylib compilation and uniffi-bindgen codegen are now cached as nix store artifacts, making CI rebuilds near-instant on cache hit. Update CI workflow to use `nix build .#dart-bindings` and `nix build .#kotlin-bindings` instead of `nix develop --command just binding-*`. Outputs are copied to the expected directory layout so existing test commands continue to work unchanged.
crodas
force-pushed
the
feature/binding-kotlin
branch
5 times, most recently
from
0a508fa to
7559467
Compare
thesimplekid
reviewed
Apr 1, 2026
The three per-binding rust-toolchain.toml files were identical copies of the root one with cross-compilation targets added. Merge the targets into the root file and replace the duplicates with symlinks, since native_toolchain_rust (Dart) expects the file in the crate directory.
crodas
force-pushed
the
feature/binding-kotlin
branch
from
7559467 to
6357afb
Compare
thesimplekid
reviewed
Apr 2, 2026
Collaborator
There was a problem hiding this comment.
Why is this different then the one we're already using for our bindings.
Collaborator
There was a problem hiding this comment.
Should we gitignore this?
Collaborator
There was a problem hiding this comment.
Looks like its also committed in cdk-kotlin so maybe we need it.
thesimplekid
approved these changes
Apr 2, 2026
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Kotlin/JVM bindings for CDK using UniFFI, following the same pattern as the existing Dart and Swift bindings. Includes a Gradle project with JNA-based native library loading, a generate-bindings.sh build script, and JUnit 5 integration tests (initial balance, mint flow) mirroring the Dart test suite.
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing