feat: add preferred_mints to payment requests#1925
Open
a1denvalu3 wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 65.14% 65.25% +0.10%
==========================================
Files 329 329
Lines 56742 56939 +197
==========================================
+ Hits 36965 37155 +190
- Misses 19777 19784 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1366643 to
b59c2b7
Compare
lescuer97
approved these changes
Apr 27, 2026
Contributor
lescuer97
left a comment
There was a problem hiding this comment.
LGTM. The errors in the CLI seem to be clippy and other errors not related to the code
Collaborator
|
Can you rebase instead of merge https://github.com/cashubtc/cdk/blob/main/DEVELOPMENT.md#keeping-your-branch-up-to-date please |
Contributor
Author
I usually rebase, but the update button under the PR was too tempting this time. |
d238cdd to
bbc1c74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preferred_mintsto Cashu Payment Requests (NUT-18 and NUT-26)PaymentRequestandCreateRequestParamsstructs withpreferred_mintsacross core, wallet, CLI, and FFImintsandpreferred_mintsare mutually exclusive during creation and decodingpay_requestselection logic to prioritizepreferred_mintsover fallback mints if they have sufficient balance