Skip to content

NUT-XX: Mint Quote Lookup by Public Key - Wallet Side#1932

Open
TheMhv wants to merge 8 commits into
cashubtc:mainfrom
TheMhv:feat/mint_quote_lookup_wallet
Open

NUT-XX: Mint Quote Lookup by Public Key - Wallet Side#1932
TheMhv wants to merge 8 commits into
cashubtc:mainfrom
TheMhv:feat/mint_quote_lookup_wallet

Conversation

@TheMhv
Copy link
Copy Markdown
Contributor

@TheMhv TheMhv commented Apr 23, 2026

Description

Depends on: #1834


Notes to the reviewers

  • Create mint_connector request for mint quote lookup by pubkeys
  • Create test utils for this implementation
  • Creates a sign message function for Wallet
  • Creates a new command in cdk-cli for get mint quotes by pubkeys

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@github-project-automation github-project-automation Bot moved this to Backlog in CDK Apr 23, 2026
@TheMhv TheMhv force-pushed the feat/mint_quote_lookup_wallet branch from 78b82b5 to 498da42 Compare April 23, 2026 19:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 0.75188% with 132 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.99%. Comparing base (73500ef) to head (2cb1c8a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/cdk/src/mint/issue/mod.rs 0.00% 52 Missing ⚠️
crates/cdk-common/src/database/mint/test/mint.rs 0.00% 33 Missing ⚠️
crates/cdk-axum/src/custom_handlers.rs 0.00% 21 Missing ⚠️
crates/cdk/src/wallet/mod.rs 0.00% 10 Missing ⚠️
crates/cdk/src/wallet/test_utils.rs 11.11% 8 Missing ⚠️
crates/cdk-sql-common/src/mint/quotes.rs 0.00% 5 Missing ⚠️
crates/cdk-axum/src/custom_router.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
- Coverage   65.12%   64.99%   -0.14%     
==========================================
  Files         329      329              
  Lines       56711    56875     +164     
==========================================
+ Hits        36934    36966      +32     
- Misses      19777    19909     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheMhv TheMhv force-pushed the feat/mint_quote_lookup_wallet branch 2 times, most recently from c19f530 to def9498 Compare April 28, 2026 13:11
@TheMhv TheMhv force-pushed the feat/mint_quote_lookup_wallet branch from def9498 to d26f9d1 Compare April 28, 2026 14:47
@TheMhv TheMhv marked this pull request as ready for review April 28, 2026 14:48
@TheMhv TheMhv changed the title (WIP) NUT-XX: Mint Quote Lookup by Public Key - Wallet Side NUT-XX: Mint Quote Lookup by Public Key - Wallet Side Apr 28, 2026
@TheMhv TheMhv force-pushed the feat/mint_quote_lookup_wallet branch from d26f9d1 to 2cb1c8a Compare May 1, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants