Add Kotlin bindings build config and CI publish workflow#1939
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
=======================================
Coverage 65.16% 65.16%
=======================================
Files 330 330
Lines 56742 56742
=======================================
Hits 36976 36976
Misses 19766 19766 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crodas
force-pushed
the
feature/kotlin-release
branch
6 times, most recently
from
fce2540 to
9856271
Compare
crodas
force-pushed
the
feature/kotlin-release
branch
from
9856271 to
c439c33
Compare
| } | ||
| publishing { | ||
| singleVariant("release") { | ||
| withSourcesJar() |
There was a problem hiding this comment.
Did you verify this by publishing to Maven Central or running Central validation? I don't think all of these publications will pass without sources and javadoc artifacts.
cdk-jvm seems to have both sources and javadocs.
cdk-android has sources but is missing javadocs.
cdk-jvm-natives and cdk-ios appear to be missing both sources and javadocs.
Central requires every non-pom artifact to include matching -sources.jar and -javadoc.jar artifacts, though placeholder jars are allowed if real sources/docs are not available:
https://central.sonatype.org/publish/requirements/#supply-javadoc-and-sources
There was a problem hiding this comment.
I will test with a throw-away maven central account or I will run the central validation
There was a problem hiding this comment.
What parts of this have been tested then if the publishing has not been?
There was a problem hiding this comment.
This PR creates a git-release, similar to dart, that includes all generated UniFFI files and the compiled binaries for each platform. With the target repository, I pull locally and run the unit tests on Linux and OSX, ensuring no Rustc is available.
I will test now the maven publication
There was a problem hiding this comment.
In the future we should note on the PR if there is outstanding testing to be done.
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
| git add -A | ||
| git diff --cached --quiet && echo "No changes to commit" && exit 0 | ||
| git commit -m "release: ${{ inputs.release_tag }} — add bindings and prebuilt binaries" |
There was a problem hiding this comment.
Doesn't the above step already committed all this so this is a duplicate?
crodas
force-pushed
the
feature/kotlin-release
branch
2 times, most recently
from
6d0b1f5 to
51b9aef
Compare
crodas
force-pushed
the
feature/kotlin-release
branch
from
51b9aef to
5358122
Compare
2 participants
Description
Add Gradle build configuration for JVM, Android, and iOS targets, along with a GitHub Actions workflow for publishing Kotlin packages.
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)