Skip to content

Auth wildcard#1967

Open
thesimplekid wants to merge 3 commits into
cashubtc:mainfrom
thesimplekid:auth_wildcard
Open

Auth wildcard#1967
thesimplekid wants to merge 3 commits into
cashubtc:mainfrom
thesimplekid:auth_wildcard

Conversation

@thesimplekid
Copy link
Copy Markdown
Collaborator

@thesimplekid thesimplekid commented May 14, 2026

Description

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@thesimplekid
fix(cdk): verify CurrencyUnit::Auth before delegating auth verification
5bcd061 
This prevents regular currency tokens from being used to bypass
authentication endpoints, effectively preventing double spending
and bypassing blind auth.
@github-project-automation github-project-automation Bot moved this to Backlog in CDK May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.27%. Comparing base (e06f337) to head (07c6358).

Files with missing lines Patch % Lines
crates/cdk/src/mint/auth/mod.rs 0.00% 2 Missing ⚠️
crates/cashu/src/nuts/auth/nut21.rs 99.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
+ Coverage   65.16%   65.27%   +0.11%     
==========================================
  Files         330      330              
  Lines       56742    56895     +153     
==========================================
+ Hits        36976    37139     +163     
+ Misses      19766    19756      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

CDK
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thesimplekid