feat: add optimized batch mint finalization#165
Draft
Egge21M wants to merge 5 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: a6e2385 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 79.82% 77.12% -2.70%
==========================================
Files 108 110 +2
Lines 11772 12409 +637
==========================================
+ Hits 9397 9571 +174
- Misses 2375 2838 +463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds output-deferred single minting and optimized BOLT11 batch mint finalization for NUT-29-capable mints.
Problem
Preparing output data at quote creation prevents multiple paid quotes from being combined into better denomination splits. That keeps single 23-sat quotes at
16,4,2,1each, instead of allowing three quotes to mint as64,4,1.Summary
cashubtc/mintd:v0.16.0..changeset/batch-minting.md.Verification
bun --cwd packages/adapter-tests typecheckbun --cwd packages/core typecheckbun --cwd packages/core test:unitbun --cwd packages/sqlite3 typecheckbun --cwd packages/sqlite-bun typecheckbun --cwd packages/expo-sqlite typecheckbun --cwd packages/indexeddb typecheck./scripts/test-integration.sh sqlite3sqlite3,sqlite-bun, andexpo-sqliteIndexedDB browser integration was skipped because Playwright does not work on this system.
Changeset
.changeset/batch-minting.md.