Tighten nut-11 spending conditions#358
Open
robwoodgate wants to merge 5 commits into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
KvngMikey
reviewed
Apr 2, 2026
KvngMikey
reviewed
Apr 2, 2026
thesimplekid
reviewed
Apr 2, 2026
Contributor
Author
|
@thesimplekid @callebtc - we have merged implementations across the core repos. |
5 tasks
a1denvalu3
reviewed
Apr 17, 2026
| - `refund: <hex_str>` are additional public keys that can provide signatures after `locktime` (_allows multiple entries_) | ||
| - `n_sigs_refund: <int>` specifies the minimum number of [Refund Multisig](#refund-multisig) public keys providing valid signatures after `locktime` expires | ||
|
|
||
| Each of the above tags may appear exactly **ONCE** in a P2PK secret. If a tag appears more than once, the P2PK secret is malformed and the Proof **MUST** be rejected as unspendable. |
Contributor
There was a problem hiding this comment.
As per discussion, we could enforce split handling on the mint and wallet sides.
- The mint could treat malformed NUT-11 as anyone-can-spend
- The wallets could reject malformed NUT-11.
Contributor
Author
There was a problem hiding this comment.
What change in wording would work for you?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes ambiguity by tightening the spending conditions to specifically reject malformed P2PK secrets.