feat: add VolumeAttachment wait after drain using cached client #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional feature to wait for VolumeAttachments to be deleted after draining a node, preventing Multi-Attach errors when CSI drivers need time to clean up volumes before the node is terminated. Uses controller-runtime's cached client with field indexes for efficient VolumeAttachment and Pod queries without hitting the API server directly. Follows Karpenter's approach of excluding VAs from non-drainable pods (DaemonSets, static pods) to avoid deadlocks. Key changes: - Add Drain config section with WaitForVolumeDetach, VolumeDetachTimeout, and CacheSyncTimeout settings - Create controller-runtime cache with field indexes for VolumeAttachment and Pod resources by spec.nodeName - Implement getVolumeAttachmentsForNode() using Karpenter-style filtering - Graceful degradation: if cache sync fails, feature is disabled but drain operations continue normally Environment variables: - DRAIN_WAIT_FOR_VOLUME_DETACH: Enable feature (default: false) - DRAIN_VOLUME_DETACH_TIMEOUT: Max wait time (default: 60s) - CACHE_SYNC_TIMEOUT: Cache sync timeout (default: 120s)
…tach The spec.nodeName field selector is not supported by the Kubernetes API server for VolumeAttachment resources. This caused the waitForVolumeDetach function to fail silently. Switch to using the controller-runtime cached client which has a custom field indexer configured for spec.nodeName lookups on VolumeAttachments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional feature to wait for VolumeAttachments to be deleted after draining a node, preventing Multi-Attach errors when CSI drivers need time to clean up volumes before the node is terminated.
Uses controller-runtime's cached client with field indexes for efficient VolumeAttachment and Pod queries without hitting the API server directly. Follows Karpenter's approach of excluding VAs from non-drainable pods (DaemonSets, static pods) to avoid deadlocks.
Key changes:
Environment variables: