[common] Add {:r} repr formatter for TypeSafeIndex and Identifier - #5
Draft
castor639 wants to merge 1 commit into
Draft
[common] Add {:r} repr formatter for TypeSafeIndex and Identifier#5castor639 wants to merge 1 commit into
castor639 wants to merge 1 commit into
Conversation
cursor
Bot
force-pushed
the
typesafeindex-repr-formatter
branch
from
August 29, 2026 17:20
ee4b6cf to
8a40c4b
Compare
Default fmt output remains the bare integer. The new {:r} specifier
prints a typed representation (e.g. FooIndex(0), FooId(1)) using
NiceTypeName. Also teach NiceTypeName to canonicalize TypeSafeIndex
the same way it already does for Identifier.
Fixes RobotLocomotion#24262.
cursor
Bot
force-pushed
the
typesafeindex-repr-formatter
branch
from
August 29, 2026 17:20
8a40c4b to
34a5f64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch targets upstream RobotLocomotion/drake. Opening that PR returned 403 for this environment's token; use the compare link below.
RobotLocomotion/drake@master...castor639:drake:typesafeindex-repr-formatter
Fixes RobotLocomotion#24262.
Adds a
{:r}(repr) format specifier forTypeSafeIndexandIdentifierso error messages can include a typed representation instead of a bare integer:Default
{}formatting is unchanged (still the underlying integer).Also teaches
NiceTypeNameto canonicalizeTypeSafeIndex<...Tag>to...Index, matching the existingIdentifier<...Tag>→...Idrule.Testing
bazel test //common:type_safe_index_test //common:identifier_test //common:nice_type_name_test(pass)//geometry:kinematics_vectorbuild (pass; GeometryId inherits Identifier formatter)