Add YouTube oEmbed support for link previews - #882
Merged
Merged
Conversation
LinkPreviewController now detects youtube.com/youtu.be (and related host variants) and fetches https://www.youtube.com/oembed?url={url}&format=json instead of scraping the page's HTML, since YouTube's client-rendered pages make OpenGraph scraping unreliable. The oEmbed response is validated with zod before being mapped onto LinkPreviewData, and falls back to the same caching/rate-limit/error-handling flow used by the generic HTML path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PCVUPdxNMWehtCNeGCmLXL
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds specialized support for YouTube URLs in the link preview system by integrating YouTube's oEmbed endpoint, providing better metadata extraction for video content.
Key Changes
isYouTubeHostname()function andYOUTUBE_HOSTNAMESset to identify YouTube URLs across multiple domains (youtube.com, youtu.be, m.youtube.com, youtube-nocookie.com, etc.)_getYouTubeOEmbedData()method to fetch preview data from YouTube's oEmbed endpoint with proper schema validation using ZodYOUTUBE_OEMBED_SCHEMAusing Zod to validate and type YouTube's oEmbed responsesextractYouTubeOEmbedData()function to map oEmbed fields onto the standardLinkPreviewDataformat_getGenericPreviewData()method and introducedPreviewDataResulttype to handle both success and failure cases uniformlyImplementation Details
unacceptable_urlerrors for invalid responseshttps://claude.ai/code/session_01PCVUPdxNMWehtCNeGCmLXL