fix: report signals ignored at shell entry - #13
Merged
Merged
Conversation
cataggar
force-pushed
the
fix/issue-6-trap-ignored-reporting
branch
from
August 19, 2026 19:17
0822eb0 to
09da86d
Compare
cataggar
force-pushed
the
fix/issue-6-trap-ignored-reporting
branch
from
August 20, 2026 02:01
09da86d to
dd40cfc
Compare
Capture inherited signal dispositions before Rust and shell internals can alter them, preserve the snapshot across clones, and include ignored signals in trap -p output. Assisted-by: GitHub Copilot CLI:gpt-5.6-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cataggar
added a commit
that referenced
this pull request
Aug 22, 2026
Capture inherited signal dispositions before Rust and shell internals can alter them, preserve the snapshot across clones, and include ignored signals in trap -p output. Assisted-by: GitHub Copilot CLI:gpt-5.6-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trap -pTests
cargo test --package brush-corecargo test --test brush-compat-tests -- 'Builtins: trap'\n-cargo fmt --all --check\n-cargo clippy --package brush-core --package brush-builtins --package brush-shell --all-features --all-targets\n\nCloses trap -p omits signals ignored at shell entry, failing OS target tests on six distros聽#6