Skip to content

making and using snapshots to improve performance #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jay-oswald merged 44 commits into from
May 27, 2026
+2,373 −261
Merged

making and using snapshots to improve performance #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
727e235
cache and restore db
jay-oswald May 26, 2026
0a12169
add version bump enforcement
jay-oswald May 20, 2026
02f0180
add flag to disable version checks
jay-oswald May 20, 2026
32de370
cleanup, enforce ints instead of floats
jay-oswald May 20, 2026
447cabc
Potential fix for pull request finding
jay-oswald May 20, 2026
98ff2d8
change is run logic to run on PR's and pushes to protected branches
jay-oswald May 21, 2026
3eb0e0f
swap de-duplicate order
jay-oswald May 21, 2026
c666620
remove de-duplicate step, causing issues
jay-oswald May 21, 2026
c79470d
only run for MOODLE_*_STABLE branches
jay-oswald May 21, 2026
2705994
Show errors as annotations
brendanheywood May 25, 2026
80cd136
Replace errors with annotations
brendanheywood May 25, 2026
87d42fc
Add time to various cli commands
brendanheywood May 25, 2026
a6f650d
Remove need to install Moodle for static analysis jobs
brendanheywood May 25, 2026
911a722
Remove db install from validate job
brendanheywood May 25, 2026
c662376
Create empty config.php file
brendanheywood May 25, 2026
0481c70
Fixed yaml escaping
brendanheywood May 25, 2026
f46de53
Ensure dataroot exists
brendanheywood May 25, 2026
c1f6dd2
cache and restore db
jay-oswald May 26, 2026
2899d4c
merge in brendans changes and use more from snapshot
jay-oswald May 26, 2026
2d28070
make data directory, fix patch apply
jay-oswald May 26, 2026
d0f9be9
restore phpunit snapshot
jay-oswald May 26, 2026
daddb7c
always install, upgrade phpunit db
jay-oswald May 26, 2026
6ce4171
old plugin install
jay-oswald May 26, 2026
40136e7
check for version before install
jay-oswald May 26, 2026
f8ccd78
stop running setup for making snapshots
jay-oswald May 26, 2026
22988e6
install locale
jay-oswald May 26, 2026
9bd9b3c
action fix
jay-oswald May 26, 2026
f7202fc
Updated 401-403 and 404-500 patch files.
May 26, 2026
a0d8e59
Updated 501 and 502 patches.
May 26, 2026
ea64a1c
fix phpunit snapshot
jay-oswald May 26, 2026
48482a1
Updated patches.
May 26, 2026
40dcaa9
Fixed phpunit buildconfig after adding the plugin
brendanheywood May 26, 2026
35509d9
Fix privacy related unit test calls
brendanheywood May 26, 2026
82fc36c
Filter tests to just critical privacy detection tests
brendanheywood May 26, 2026
5cff653
Tune postgres for speed
brendanheywood May 26, 2026
6954573
plit out DB and restore to its own step
brendanheywood May 26, 2026
4afef94
Always run privacy tests
brendanheywood May 26, 2026
8d2674e
Nicer grouping of unit tests
brendanheywood May 26, 2026
d5f2399
Move timing outside of groups
brendanheywood May 26, 2026
af67c40
Cleanup timing group titles
brendanheywood May 26, 2026
72f1581
Fix group titles
brendanheywood May 26, 2026
dbf1b25
Add groups for docker commands
brendanheywood May 26, 2026
f5b7637
Merge branch 'main' into cached-db
jay-oswald May 27, 2026
ea9eed5
Updated patches with mariadb fix.
May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions .github/actions/matrix/matrix_includes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
include:
# Always include main (issue #18) - disable-able by config by setting 'disable_master' to true
- {moodle-branch: 'main', php: '8.4', node: '22', mariadb-ver: '10.11', pgsql-ver: '16', database: 'pgsql'}
- {moodle-branch: 'main', php: '8.4', node: '22', pgsql-ver: '16', database: 'pgsql'}
# Test all variants of 5.2
- { moodle-branch: 'MOODLE_502_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', pgsql-ver: '16', database: 'mariadb' }
- { moodle-branch: 'MOODLE_502_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', pgsql-ver: '16', database: 'pgsql' }
- { moodle-branch: 'MOODLE_502_STABLE', php: '8.3', node: '22', mariadb-ver: '10.11', pgsql-ver: '16', database: 'mariadb' }
- { moodle-branch: 'MOODLE_502_STABLE', php: '8.3', node: '22', mariadb-ver: '10.11', pgsql-ver: '16', database: 'pgsql' }
- { moodle-branch: 'MOODLE_502_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', database: 'mariadb' }
- { moodle-branch: 'MOODLE_502_STABLE', php: '8.4', node: '22', pgsql-ver: '16', database: 'pgsql' }
- { moodle-branch: 'MOODLE_502_STABLE', php: '8.3', node: '22', mariadb-ver: '10.11', database: 'mariadb' }
- { moodle-branch: 'MOODLE_502_STABLE', php: '8.3', node: '22', pgsql-ver: '16', database: 'pgsql' }
# Test all variants of 5.1
- { moodle-branch: 'MOODLE_501_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', pgsql-ver: '15', database: 'mariadb' }
- { moodle-branch: 'MOODLE_501_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', pgsql-ver: '15', database: 'pgsql' }
- { moodle-branch: 'MOODLE_501_STABLE', php: '8.2', node: '22', mariadb-ver: '10.11', pgsql-ver: '15', database: 'mariadb' }
- { moodle-branch: 'MOODLE_501_STABLE', php: '8.2', node: '22', mariadb-ver: '10.11', pgsql-ver: '15', database: 'pgsql' }
- { moodle-branch: 'MOODLE_501_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', database: 'mariadb' }
- { moodle-branch: 'MOODLE_501_STABLE', php: '8.4', node: '22', pgsql-ver: '15', database: 'pgsql' }
- { moodle-branch: 'MOODLE_501_STABLE', php: '8.2', node: '22', mariadb-ver: '10.11', database: 'mariadb' }
- { moodle-branch: 'MOODLE_501_STABLE', php: '8.2', node: '22', pgsql-ver: '15', database: 'pgsql' }
# Test limited variants of 5.0
- { moodle-branch: 'MOODLE_500_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', pgsql-ver: '14', database: 'mariadb' }
- { moodle-branch: 'MOODLE_500_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', pgsql-ver: '14', database: 'pgsql' }
- { moodle-branch: 'MOODLE_500_STABLE', php: '8.4', node: '22', mariadb-ver: '10.11', database: 'mariadb' }
- { moodle-branch: 'MOODLE_500_STABLE', php: '8.4', node: '22', pgsql-ver: '14', database: 'pgsql' }
# Test all variants of 4.5. (LTS).
- { moodle-branch: 'MOODLE_405_STABLE', php: '8.3', node: '22', mariadb-ver: '10.6', pgsql-ver: '13', database: 'mariadb' }
- { moodle-branch: 'MOODLE_405_STABLE', php: '8.3', node: '22', mariadb-ver: '10.6', pgsql-ver: '13', database: 'pgsql' }
- { moodle-branch: 'MOODLE_405_STABLE', php: '8.1', node: '22', mariadb-ver: '10.6', pgsql-ver: '13', database: 'mariadb' }
- { moodle-branch: 'MOODLE_405_STABLE', php: '8.1', node: '22', mariadb-ver: '10.6', pgsql-ver: '13', database: 'pgsql' }
- { moodle-branch: 'MOODLE_405_STABLE', php: '8.3', node: '22', mariadb-ver: '10.6', database: 'mariadb' }
- { moodle-branch: 'MOODLE_405_STABLE', php: '8.3', node: '22', pgsql-ver: '13', database: 'pgsql' }
- { moodle-branch: 'MOODLE_405_STABLE', php: '8.1', node: '22', mariadb-ver: '10.6', database: 'mariadb' }
- { moodle-branch: 'MOODLE_405_STABLE', php: '8.1', node: '22', pgsql-ver: '13', database: 'pgsql' }
# Test all variants of 4.1 (LTS).
- { moodle-branch: 'MOODLE_401_STABLE', php: '7.4', node: '22', mariadb-ver: '10.5', pgsql-ver: '12', database: 'mariadb' }
- { moodle-branch: 'MOODLE_401_STABLE', php: '7.4', node: '22', mariadb-ver: '10.5', pgsql-ver: '12', database: 'pgsql' }
- { moodle-branch: 'MOODLE_401_STABLE', php: '8.0', node: '22', mariadb-ver: '10.5', pgsql-ver: '12', database: 'mariadb' }
- { moodle-branch: 'MOODLE_401_STABLE', php: '8.0', node: '22', mariadb-ver: '10.5', pgsql-ver: '12', database: 'pgsql' }
- { moodle-branch: 'MOODLE_401_STABLE', php: '7.4', node: '22', mariadb-ver: '10.5', database: 'mariadb' }
- { moodle-branch: 'MOODLE_401_STABLE', php: '7.4', node: '22', pgsql-ver: '12', database: 'pgsql' }
- { moodle-branch: 'MOODLE_401_STABLE', php: '8.0', node: '22', mariadb-ver: '10.5', database: 'mariadb' }
- { moodle-branch: 'MOODLE_401_STABLE', php: '8.0', node: '22', pgsql-ver: '12', database: 'pgsql' }
27 changes: 20 additions & 7 deletions .github/actions/parse-version/script.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,22 +248,35 @@ function container_image_name($moodle_branch, $php) {
usort($phpVersions, 'version_compare');
$highestPhp = end($phpVersions);
output('highest_php', $highestPhp);
// Find the container and node for this combo
// Find the container and node for this combo.
// Prefer the pgsql entry when present so latest_pgsql_ver is reliably populated.
$foundNode = '';
$foundPgsqlVer = '';
foreach ($finalMatrix as $entry) {
if ($entry['moodle-branch'] === $highestMoodleBranch && $entry['php'] === $highestPhp) {
output('latest_container', $entry['container']);
if (isset($entry['pgsql-ver'])) {
output('latest_pgsql_ver', $entry['pgsql-ver']);
} else {
output('latest_pgsql_ver', '');
}
if (isset($entry['node'])) {
$foundNode = $entry['node'];
}
break;
if (($entry['database'] ?? '') === 'pgsql' && isset($entry['pgsql-ver'])) {
$foundPgsqlVer = $entry['pgsql-ver'];
break;
}
}
}

// If no exact highest-php pgsql entry was found, fallback to any pgsql for the highest branch.
if ($foundPgsqlVer === '') {
foreach ($finalMatrix as $entry) {
if ($entry['moodle-branch'] === $highestMoodleBranch && ($entry['database'] ?? '') === 'pgsql' && isset($entry['pgsql-ver'])) {
$foundPgsqlVer = $entry['pgsql-ver'];
break;
}
}
}

output('latest_pgsql_ver', $foundPgsqlVer);

// If node version not found above, fallback to highest node version
if (!$foundNode && !empty($nodeVersions)) {
usort($nodeVersions, 'version_compare');
Expand Down
Loading
Loading