Fix codechecker issues so CI passes

[MagnusSamuelsson]

This PR fixes the issues reported by Moodle codechecker. After these changes, the CI tests pass without errors.

[MagnusSamuelsson]

Hmm... That went sideways....

[MagnusSamuelsson]

Looks like bad timing. The test failed because time() was evaluated in a different second when creating the key versus asserting the expected value:

1) auth_userkey\core_userkey_manager_test::test_create_correct_key_if_iprestriction_is_false
Failed asserting that '1765964965' matches expected 1765964966.

Maybe it's a good idea to add a delta to this test. What do you say?

This is probably a more stable approach:
MagnusSamuelsson@697c41c

[dmitriim]

thanks @MagnusSamuelsson
Merged

[MagnusSamuelsson]

@dmitriim You are welcome!
Do you want a pr for the delta assert? Or will you update it?

[dmitriim]

@MagnusSamuelsson
Do you mean fixing #115 ? IF you have capacity, then please do.

[MagnusSamuelsson]

Yes, there is a fix already at my gh.
I couldn't just leave it after fixing the tests, and the first thing that happened was tests failing 🤣