Skip to content

Test accounting for reload generations, plus the stray plugin state - #1

Closed
jorgeccastro wants to merge 7 commits into
catlee:fix/plugin-hot-reloadfrom
jorgeccastro:pr8766/ipc-count-across-generations
Closed

jorgeccastro wants to merge 7 commits into
catlee:fix/plugin-hot-reloadfrom
jorgeccastro:pr8766/ipc-count-across-generations

Conversation

@jorgeccastro

@jorgeccastro jorgeccastro commented Aug 30, 2026 •

Copy link
Copy Markdown

The two commits I offered in omacom#8766.

  • Fix IPC handler count across reload generations (test only). The collision
    assertion in runtime-smoke-test.sh allowed screens - 1 warnings for the
    whole log, but the log now spans every soft reload, so the allowance has to
    scale with the number of loaded generations.
  • Remove unused Hyprland plugin state. Drops the hyprlandPluginState
    property you identified as a leak from Allow plugins to register hyprland overrides omacom/omarchy#8396.

Based on f2b1fb5a, the current head of the PR.

Verified on Omarchy 4.0.1, Quickshell 0.3.1, Hyprland 0.56.2, two monitors:

local-plugin-watcher-test.sh: PASS
runtime-smoke-test.sh:        PASS

@jorgeccastro

Copy link
Copy Markdown
Author

Closing this: the rewritten branch now carries these two changes as 1bd3d26 and 2a6f31c (same generation accounting, same stray property removal), so there is nothing left here to merge. Glad they landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants