ci: test TypeScript client on supported Node versions - #1026
Open
mikemikimike wants to merge 1 commit into
Open
mikemikimike wants to merge 1 commit into
mikemikimike wants to merge 1 commit into
Conversation
Member
|
Thank you for adding the supported Node-version matrix. The Node 18, 20, and 22 jobs pass, but DCO still fails because the functional commit 5e09689 does not contain your Signed-off-by trailer. Please add the sign-off to that commit yourself, rebase onto current main, and force-push the updated branch; we will rerun exact-head CI and review after that. |
mikemikimike
force-pushed
the
fix/issue-973-ci-node-matrix
branch
from
September 6, 2026 13:21
e569d61 to
e65f5f9
Compare
mikemikimike
force-pushed
the
fix/issue-973-ci-node-matrix
branch
2 times, most recently
from
September 21, 2026 23:05
0d83e13 to
3b0c8fc
Compare
Signed-off-by: mikemikimike <13286568797@163.com>
mikemikimike
force-pushed
the
fix/issue-973-ci-node-matrix
branch
from
September 21, 2026 23:11
3b0c8fc to
47ae5df
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Problem
Closes #973. The TypeScript client workflow only exercised Node 20 even though the package declares Node >=18, and it used
npm installdespite the committed lockfile.Changes
npm cifor deterministic lockfile-based installs.Tests
npm ci(fromclients/typescript) — passed.npm test(fromclients/typescript) — passed; 14 tests passed.git diff --check— passed.Compatibility / Known limitations
This changes CI coverage and dependency installation only; it does not change the published client API or runtime behavior. The three Node versions will be exercised by the hosted GitHub Actions workflow after the PR is opened.
Issue link
Closes #973