chore(client-typescript): add a Prettier lint gate to the TypeScript client CI - #1622
Merged
Merged
Conversation
Contributor
|
Claude Code Review — skipped: PR author 'erni-a' is not a public member of the 'caura-ai' org |
arkash20
previously approved these changes
Sep 20, 2026
erni-a
force-pushed
the
chore/ts-client-lint-gate
branch
from
September 20, 2026 04:40
bd4f20b to
1c32eb0
Compare
Contributor
|
Claude Code Review — skipped: PR author 'erni-a' is not a public member of the 'caura-ai' org |
Contributor
Author
|
Rebased onto main after #1561 (User-Agent header) touched the same test file and package.json. Conflicts resolved by taking main's versions and re-applying the lint-gate edits; tsc clean, 33/33 pass, lint clean. The force-push dismissed the earlier approval, so re-requesting review, @arkash20. Diff vs main is unchanged in intent: workflow step, .prettierrc, package.json scripts + prettier devDependency, and the reformat. |
arkash20
approved these changes
Sep 20, 2026
arkash20
approved these changes
Sep 20, 2026
…client CI Closes #1403. The Python client CI runs ruff before pytest; the TypeScript client CI ran only tsc + node --test, so formatting drift was never caught. Take the smaller of the two routes the issue offers: Prettier --check, not ESLint. It needs one dev dependency and one config key, and the source is ~300 lines, which does not justify a rule set to maintain. - clients/typescript/.prettierrc: printWidth 110, matching the line-length = 110 the repo's ruff config already uses for Python, so both clients wrap at the same column. Everything else is Prettier's default. - package.json: prettier ^3.6 as a devDependency (pinned through the lockfile, so CI and local runs agree), plus lint and format scripts so contributors run exactly what CI runs. - client-typescript-ci.yml: a Lint (prettier) step before Build + test, mirroring the Python workflow's ordering. - src/: the reformat the first run reports. No logic change; tsc clean and 31/31 tests pass. npm install and the Node-20-only matrix stay as they are; #973 tracks them. Signed-off-by: erni <erni@caura.ai>
erni-a
force-pushed
the
chore/ts-client-lint-gate
branch
from
September 20, 2026 04:47
1c32eb0 to
0693669
Compare
Contributor
|
Claude Code Review — skipped: PR author 'erni-a' is not a public member of the 'caura-ai' org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1403.
The Python client CI runs ruff before pytest; the TypeScript client CI ran only
tscandnode --test, so nothing caught formatting drift. This takes the smaller of the two routes the issue offers, Prettier--check, not ESLint: one dev dependency, one config key, and the source is about 300 lines, which does not justify a rule set to maintain. ESLint stays available as a later step if the client grows.clients/typescript/.prettierrc:printWidth: 110, matching theline-length = 110the repo's ruff config already uses for Python, so both clients wrap at the same column. Everything else is Prettier's default.package.json:prettier ^3.6as a devDependency (pinned through the lockfile, so CI and local runs agree), pluslintandformatscripts so contributors run exactly what CI runs.client-typescript-ci.yml: aLint (prettier)step beforeBuild + test, mirroring the Python workflow's ordering.src/: the reformat the first run reports. No logic change.npm installand the Node-20-only matrix are left alone; #973 tracks them. Stacked on #1621 (same workflow file); merge that first and this rebases clean.Related Issue
Closes #1403.
Type of Change
How Has This Been Tested?
npm run lintfails onmain's source and passes after the reformat.npm test: tsc clean, 31/31 pass on Node 20..prettierrcis not in the packagefileslist, so the published tarball is unchanged.clients/typescript/**, so this PR triggers it and the new step is visible in the job log.Checklist