Andrew miksch/em practical skills - #37
Open
superandrew123 wants to merge 9 commits into
Open
superandrew123 wants to merge 9 commits into
superandrew123 wants to merge 9 commits into
Conversation
superandrew123
marked this pull request as draft
July 23, 2024 18:18
superandrew123
commented
Jul 23, 2024
| # your test database is "scratch space" for the test suite and is wiped | ||
| # and recreated between test runs. Don't rely on the data there! | ||
| config.cache_classes = true | ||
| # config.cache_classes = true |
Author
There was a problem hiding this comment.
This change was needed for the test DB to create.
superandrew123
marked this pull request as ready for review
July 23, 2024 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked on this for a bit longer than i should so came to a good stopping point rather than pushing for perfection. Here's my theoretical list of to-dos:
UsersArticlesController#createshould get extracted into a creator service object with unit testsfakeweb,webmock, orvcrto get better tests around the external apicapybara(this is a weak point in my skill set)