Skip to content

Updated octave_notes.txt #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbm755 merged 2 commits into from
Apr 28, 2025
Merged

Updated octave_notes.txt #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
593499b
Update octave_notes.txt
kolmanthomas Apr 28, 2025
3cb562a
Merge pull request #1 from kolmanthomas/kolmanthomas-patch-1
kolmanthomas Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions octave_notes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,13 @@ If really you want to use functions without the dot, there is another
feature: "class-related function" which are also private to the m-file
(and not e.g., methods of the class defined in other m-files).

Newer notes
-----------

Comments on existing commits:
- [octave: temporary workaround for f.funs{j}] not quite sure what the error is here, chaining subsref seems to work when I create toy examples
- [silence warning by reordering switch]: no longer produces a warning when fieldnames is called on a classdef
Copy link
Owner

@cbm755 cbm755 Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean this particular patch is not longer needed?

Copy link
Collaborator Author

@kolmanthomas kolmanthomas Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't think those two patches are needed anymore, though I might be wrong about the subsref one, I'm not sure what the original problem was or what the workaround was designed to achieve

Copy link
Owner

@cbm755 cbm755 Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can try reverting that commit, check that test octave_tests passes and sending a MR against octave_dev25?

- [TEMPORARY: remove the domain class and replace with domain.m] domain class is deprecated, may not need to implement; still, fixing the subclassing of built-in types might be a good idea
- [octave: use static methods instead of class-related functions] functions after classdefs are now supported in Octave, see https://savannah.gnu.org/bugs/?41723. There is little difference (in my view) between private static class methods and class-related functions