Skip to content

fix(tui): ignore stale auto review completions#300

Merged
shiny-code-bot merged 1 commit into
mainfrom
fix/auto-review-stale-completions
Jun 1, 2026
Merged

fix(tui): ignore stale auto review completions#300
shiny-code-bot merged 1 commit into
mainfrom
fix/auto-review-stale-completions

Conversation

@shiny-code-bot
Copy link
Copy Markdown
Collaborator

Summary

  • carry Auto Review owner session and worktree-base metadata through agent status updates
  • ignore stale or cross-session Auto Review completions before they can clear active review state or surface findings
  • guard direct background-review lifecycle completions with the same session/snapshot identity checks
  • add regressions for stale terminal completions, cross-session completions, skip-sentinel completions, and direct finished events

Validation

  • cargo test -p code-tui stale_auto_review --features test-helpers
  • cargo test -p code-tui stale_background_review_finished_event_does_not_clear_current_review --features test-helpers
  • cargo test -p code-tui cross_session_auto_review_status_does_not_surface_findings --features test-helpers
  • cargo test -p code-tui background_review_observe --features test-helpers
  • ./build-fast.sh

Notes

This is a first reliability slice for #76. Review agents flagged the skip-sentinel ordering hole and the direct-finished-event bypass; both are covered here before merge.

@shiny-code-bot shiny-code-bot merged commit b674b4e into main Jun 1, 2026
1 check passed
@shiny-code-bot shiny-code-bot deleted the fix/auto-review-stale-completions branch June 1, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants