Skip to content

Scope live target runtime sync to product expectations#1116

Merged
cbusillo merged 1 commit into
mainfrom
live-target-runtime-product-scope
Jun 2, 2026
Merged

Scope live target runtime sync to product expectations#1116
cbusillo merged 1 commit into
mainfrom
live-target-runtime-product-scope

Conversation

@cbusillo
Copy link
Copy Markdown
Owner

@cbusillo cbusillo commented Jun 2, 2026

Summary

  • scope live-target-runtime desired env to the selected product profile lane's expected runtime keys and runtime managed-secret bindings
  • require the legacy CLI apply-live-target path to provide --product so it cannot bypass product scoping
  • evaluate runtime key-safety against matching global/context/instance runtime secret bindings and document the service boundary

Agent review fixes

  • closed the CLI bypass by threading required product through the CLI wrapper
  • moved Postgres schema setup inside close-safe try/finally blocks
  • reused the canonical runtime key-safety environment classifier
  • covered context-scoped runtime managed secrets in safety evaluation/tests
  • updated service-boundary docs to say profile-declared keys are the sync boundary

Validation

  • uv run --extra dev ruff check control_plane/live_target_runtime.py control_plane/service.py control_plane/cli_runtime_environments.py control_plane/cli.py tests/test_service.py tests/test_runtime_environments.py tests/test_dokploy.py
  • uv run --extra dev ruff format --check control_plane/live_target_runtime.py control_plane/service.py control_plane/cli_runtime_environments.py control_plane/cli.py tests/test_service.py tests/test_runtime_environments.py tests/test_dokploy.py
  • uv run --extra dev mypy control_plane tests
  • npx --yes markdownlint-cli2 docs/secrets.md docs/service-boundary.md
  • uv run python -m unittest (1,972 tests)

@cbusillo cbusillo merged commit 9372312 into main Jun 2, 2026
12 checks passed
@cbusillo cbusillo deleted the live-target-runtime-product-scope branch June 2, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant