Retire satisfied onboarding secret placeholders#1121
Merged
Conversation
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ambiguous_bindingMotivation
After PR #1120 deployed and Odoo CM onboarding was reapplied,
odoo-tenant-cm/cm/testinglive-target-runtime dry-run failed closed with:26846962611launchplane_req_e659c2d33997484b85ef029951de6fe9runtime_key_safety_failedambiguous_bindingThe likely cause is a configured context-level Odoo testing binding plus the newly imported instance-level disabled placeholder. Live-target-runtime treats context-level bindings as satisfying the instance route; onboarding previously skipped only exact context+instance matches.
Validation
uv run --extra dev ruff check control_plane/workflows/product_onboarding.py tests/test_product_onboarding.pyuv run --extra dev ruff format --check control_plane/workflows/product_onboarding.py tests/test_product_onboarding.pyuv run --extra dev mypy control_plane testsuv run python -m unittest tests.test_product_onboarding