Skip to content

Allow under-target quality knob followups#119

Merged
shiny-code-bot merged 1 commit into
mainfrom
fix-under-target-quality-knobs
May 31, 2026
Merged

Allow under-target quality knob followups#119
shiny-code-bot merged 1 commit into
mainfrom
fix-under-target-quality-knobs

Conversation

@shiny-code-bot
Copy link
Copy Markdown
Collaborator

Summary

  • Treat under-target quality follow-ups as allowed when they improve quality-related video knobs, not only VMAF/XPSNR targets.
  • Reuse the same quality-improvement detection in the final approval gate so approval stays in sync with preview alignment.
  • Add regression coverage for under-target grain increases in preview and approval.

Verification

  • uv run --with pytest pytest -q tests/test_tuning_runtime.py -k "under_target_size_budget_quality"
  • uv run --with pytest pytest -q tests/test_encode_queue_recovery.py -k "under_target_quality"
  • uv run --with pytest pytest -q tests/test_tuning_runtime.py tests/test_encode_queue_recovery.py
  • bash scripts/pre-commit-check.sh
  • uv run /Users/cbusillo/Developer/codex-skills/jetbrains-inspection/scripts/jb-inspect.py closeout --repo /Users/cbusillo/Developer/mediaforce --scope changed_files

@shiny-code-bot shiny-code-bot merged commit c90db2c into main May 31, 2026
5 checks passed
@shiny-code-bot shiny-code-bot deleted the fix-under-target-quality-knobs branch May 31, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants