Fix desktop app not opening / engine not starting (v1.1.1) - #4
Merged
Merged
Conversation
- A listen error other than EADDRINUSE on the fixed port (Windows returns EACCES for ports in Hyper-V/WSL/Docker excluded ranges) left startup rejected with no window while the process kept running and holding the single-instance lock, so every later launch silently did nothing. Fall back to a random port on any listen error; if startup still fails, show an error box and exit. - Electron's BrowserWindow doesn't honor COOP/COEP, so SharedArrayBuffer was undefined and the multi-threaded engine never started. Enable it with the SharedArrayBuffer feature switch. - second-instance: show/focus the window, or create one if none exists. - Portable .exe shows a splash screen while it unpacks. Verified in real Electron (dev and packaged) under Xvfb: engine runs multi-threaded, port-taken fallback works, second launch hands off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZHKbLKcpoa8QJGzqkbDTJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, the v1.1.0
.exedoes nothing when launched. This PR fixes the two causes.EADDRINUSE,startServerrejects and nothing handles it. On Windows, a port inside a Hyper-V/WSL/Docker reserved range fails withEACCES. The app then creates no window, but the process keeps running and holds the single-instance lock, so every later launch exits silently. Now any listen error falls back to a random port. If startup still fails, the app shows an error box and exits.BrowserWindowdoesn't honor COOP/COEP, socrossOriginIsolatedstays false andSharedArrayBufferis undefined. The multi-threaded engine therefore couldn't start. v1.0.0 never hit this because it was actually running the single-threaded build. The fix isapp.commandLine.appendSwitch('enable-features', 'SharedArrayBuffer').Also in this PR:
.exenow shows a splash screen while it unpacks its ~320MB.docs/release-notes/v1.1.1.md.Testing
npm run lint,npm test(45 tests) andnpm run buildpass.EACCES, then confirmed the fallback port and the error-box path.linux-unpackedbuild:🤖 Generated with Claude Code
https://claude.ai/code/session_017ZHKbLKcpoa8QJGzqkbDTJ
Generated by Claude Code