chore(meta): harden version-linearity script and ci pin#2
Merged
cchinchilla-dev merged 1 commit intomainfrom Apr 29, 2026
Merged
chore(meta): harden version-linearity script and ci pin#2cchinchilla-dev merged 1 commit intomainfrom
cchinchilla-dev merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Hardens the repo’s version-linearity CI gate by improving error reporting in the check_version_linearity script, adding regression tests for malformed/missing version metadata, and supply-chain hardening in CI via action pinning.
Changes:
- Add actionable failure messages for malformed
pyproject.tomland missing[project].version. - Add regression tests covering malformed TOML and missing version key.
- Pin
actions/setup-pythonby commit SHA in CI and remove an unnecessary# type: ignorein the script loader test helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/scripts/test_version_linearity.py |
Adds regression tests for malformed/missing pyproject.toml version and tightens module import helper typing. |
scripts/check_version_linearity.py |
Wraps TOML parsing with targeted exception handling to produce clearer CI failures. |
.github/workflows/ci.yml |
Pins actions/setup-python to a specific SHA for more deterministic, hardened CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the Copilot review fixes from agentloom #136.
check_version_linearity.py: catchTOMLDecodeError,KeyError,TypeErrorso CI failures are actionable.[project].version.module_from_spec; drop# type: ignore.actions/setup-pythonby SHA.Tests: 11/11 green.
python scripts/check_version_linearity.py→OK: 0.1.1.