Repository navigation
fix: keep menu bar style options inside the settings card - #143
Merged
Merged
Conversation
The seven-option segmented Style picker could not shrink to the settings column in English, Japanese or Korean, so it overflowed both sides of the card. Show each style as a preview tile instead, so every language uses the same layout and users can compare styles without selecting each one. The tiles follow the current Info and Source settings, which makes the separate preview below the card redundant. The Info picker keeps its segments and falls back to a menu only when they cannot fit the column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In English, Japanese and Korean, the seven-option Style picker in Settings → Menu Bar is wider than the settings column even at its narrowest, so it spills over both sides of the card. Chinese only just fits. This replaces it with a grid of preview tiles, one per style, so the layout no longer depends on label length.
MenuBarStylePreviewwith the current Info and Source settings, so the selected tile shows exactly what the menu bar will display. Style names like "Ticks" or "Star trails" don't describe the look on their own.settingsFittingPickerfalls back to a menu if a translation ever outgrows the column.MeasuredAtWidthmeasures the segments at the column width rather than their full width, which is why Chinese doesn't fall back as well.menuBarStyle; existing choices carry over.Evidence
Settings → Menu Bar, rendered from
mainand from this branch with the same width and dark appearance.